> For the complete documentation index, see [llms.txt](https://antonio-iuliano1993.gitbook.io/software-notes/llms.txt). Markdown versions of documentation pages are available by appending `.md` to page URLs; this page is available as [Markdown](https://antonio-iuliano1993.gitbook.io/software-notes/fairship/pull-request-hints.md).

# Pull request hints

Publish your code to the Collaboration

## Intro

I will report here the common complaints and pitfalls, I refer to the Python and C++ guidelines for details

### Indentation

Visual Studio Code messes up tabs and indentations. Check if code runs locally and on lxplus, use the "Convert Indentation to Spaces" after finishing the code job. Check the code with emacs for any doubt (it may look differently).

For new code, programs such as[ black ](https://github.com/psf/black)can fix formatting for you automatically

### Operator spacing

Check that there is \*\*always 1 space bedf

## Stubs!

static analysis really does not like seeing functions he does not know about in python (because defined in C++), we need to add a stub in `stubs/ROOT/__init__.pyi`